Thread (37 messages) 37 messages, 5 authors, 2024-02-06

Re: [PATCH v3 05/24] media: i2c: switch to use of_graph_get_next_device_endpoint()

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: 2024-02-06 02:06:06
Also in: dri-devel, linux-amlogic, linux-arm-msm, linux-devicetree, linux-media, linux-omap, linux-renesas-soc, linux-samsung-soc, linux-sound, linux-staging, linux-tegra, llvm

Hi Rob, again
quoted
This is assuming there's just 1 port and 1 endpoint, but let's be 
specific as the bindings are (first endpoint on port 0):

of_graph_get_endpoint_by_regs(client->dev.of_node, 0, -1);

Note we could ask for endpoint 0 here, but the bindings generally allow 
for more than 1.

I imagine most of the other cases here are the same.
I'm bit confused here.
You mentioned that -1 is wrong in previous mail.

	Most cases are in the form of of_graph_get_next_endpoint(dev, NULL) 
	which is equivalent to of_graph_get_endpoint_by_regs(dev, 0, 0). 
	Technically, -1 instead of 0 is equivalent, but I'd argue is sloppy and 
	wrong.

But you mentioned -1 here, So, I will use it on next patch-set.


Thank you for your help !!

Best regards
---
Renesas Electronics
Ph.D. Kuninori Morimoto
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help