Re: [PATCH v3 02/24] of: property: use unsigned int return on of_graph_get_endpoint_count()
From: Dmitry Baryshkov <hidden>
Date: 2024-01-31 06:30:22
Also in:
dri-devel, linux-amlogic, linux-arm-msm, linux-devicetree, linux-media, linux-omap, linux-renesas-soc, linux-samsung-soc, linux-sound, linux-staging, linux-tegra, llvm
On Wed, 31 Jan 2024 at 07:05, Kuninori Morimoto [off-list ref] wrote:
The return type and the variable of of_graph_get_endpoint_count() should be unsigned. Tidyup it.
'the variable'? I'd have added a few words telling that return type can be unsigned because there is no error reporting for this function.
quoted hunk ↗ jump to hunk
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/of/property.c | 2 +- include/linux/of_graph.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/of/property.c b/drivers/of/property.c index 4e879faa1710..25d73409aeee 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c@@ -817,7 +817,7 @@ EXPORT_SYMBOL(of_graph_get_remote_port); * * Return: count of endpoint of this device node */ -int of_graph_get_endpoint_count(const struct device_node *np) +unsigned int of_graph_get_endpoint_count(const struct device_node *np) { struct device_node *endpoint; int num = 0;diff --git a/include/linux/of_graph.h b/include/linux/of_graph.h index 4d7756087b6b..a4bea62bfa29 100644 --- a/include/linux/of_graph.h +++ b/include/linux/of_graph.h@@ -41,7 +41,7 @@ struct of_endpoint { bool of_graph_is_present(const struct device_node *node); int of_graph_parse_endpoint(const struct device_node *node, struct of_endpoint *endpoint); -int of_graph_get_endpoint_count(const struct device_node *np); +unsigned int of_graph_get_endpoint_count(const struct device_node *np); struct device_node *of_graph_get_port_by_id(struct device_node *node, u32 id); struct device_node *of_graph_get_next_endpoint(const struct device_node *parent, struct device_node *previous);@@ -68,7 +68,7 @@ static inline int of_graph_parse_endpoint(const struct device_node *node, return -ENOSYS; } -static inline int of_graph_get_endpoint_count(const struct device_node *np) +static inline unsigned int of_graph_get_endpoint_count(const struct device_node *np) { return 0; } --2.25.1
-- With best wishes Dmitry