Re: [PATCH v3 05/24] media: i2c: switch to use of_graph_get_next_device_endpoint()
From: Rob Herring <robh@kernel.org>
Date: 2024-02-02 17:49:44
Also in:
dri-devel, linux-amlogic, linux-arm-msm, linux-devicetree, linux-media, linux-omap, linux-renesas-soc, linux-samsung-soc, linux-sound, linux-staging, linux-tegra, llvm
On Wed, Jan 31, 2024 at 05:05:27AM +0000, Kuninori Morimoto wrote:
quoted hunk ↗ jump to hunk
of_graph_get_next_endpoint() is now renamed to of_graph_get_next_device_endpoint(). Switch to it. Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- drivers/media/i2c/adv7343.c | 2 +- drivers/media/i2c/adv748x/adv748x-core.c | 2 +- drivers/media/i2c/adv7604.c | 2 +- drivers/media/i2c/isl7998x.c | 2 +- drivers/media/i2c/max9286.c | 2 +- drivers/media/i2c/mt9p031.c | 2 +- drivers/media/i2c/mt9v032.c | 2 +- drivers/media/i2c/ov2659.c | 2 +- drivers/media/i2c/ov5645.c | 2 +- drivers/media/i2c/ov5647.c | 2 +- drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +- drivers/media/i2c/s5k5baf.c | 2 +- drivers/media/i2c/tc358743.c | 2 +- drivers/media/i2c/tda1997x.c | 2 +- drivers/media/i2c/tvp514x.c | 2 +- drivers/media/i2c/tvp5150.c | 4 ++-- drivers/media/i2c/tvp7002.c | 2 +- 17 files changed, 18 insertions(+), 18 deletions(-)diff --git a/drivers/media/i2c/adv7343.c b/drivers/media/i2c/adv7343.c index ff21cd4744d3..7e4eb2f8bf0d 100644 --- a/drivers/media/i2c/adv7343.c +++ b/drivers/media/i2c/adv7343.c@@ -403,7 +403,7 @@ adv7343_get_pdata(struct i2c_client *client) if (!IS_ENABLED(CONFIG_OF) || !client->dev.of_node) return client->dev.platform_data; - np = of_graph_get_next_endpoint(client->dev.of_node, NULL); + np = of_graph_get_next_device_endpoint(client->dev.of_node, NULL);
This is assuming there's just 1 port and 1 endpoint, but let's be specific as the bindings are (first endpoint on port 0): of_graph_get_endpoint_by_regs(client->dev.of_node, 0, -1); Note we could ask for endpoint 0 here, but the bindings generally allow for more than 1. I imagine most of the other cases here are the same.
quoted hunk ↗ jump to hunk
if (!np) return NULL;diff --git a/drivers/media/i2c/adv748x/adv748x-core.c b/drivers/media/i2c/adv748x/adv748x-core.c index 3eb6d5e8f082..4e9e4cef8954 100644 --- a/drivers/media/i2c/adv748x/adv748x-core.c +++ b/drivers/media/i2c/adv748x/adv748x-core.c@@ -657,7 +657,7 @@ static int adv748x_parse_dt(struct adv748x_state *state) bool in_found = false; int ret; - for_each_endpoint_of_node(state->dev->of_node, ep_np) { + for_each_device_endpoint_of_node(state->dev->of_node, ep_np) {
I would skip the rename. Rob