Re: [PATCH] video: logo: LOGO should depend on FB_CORE i.s.o. FB

Hi Javier

Am 25.07.23 um 21:53 schrieb Javier Martinez Canillas:

Thomas Zimmermann [off-list ref] writes:

quoted

Hi

[...]

quoted

quoted

Yes. I meant to move drivers/video/logo/ to drivers/fbdev/core/logo and to
source its Kconfig from drivers/fbdev/core/Kconfig, since it now depends
on FB_CORE.

No, please rather leave it where it is. There's no code dependencies to
the fbdev core; it merely depends on the Kconfig token.

Sure, fine by me. But I disagree that there's merely a Kconfig dependency.
The include/linux/linux_logo.h header declares both fb_find_logo() and
fb_append_extra_logo().

The fb_find_logo() function is defined in drivers/video/logo.c while the
fb_append_extra_logo() is in drivers/video/fbdev/core/fbmem.c, even though
only arch/powerpc/platforms/cell/spu_base.c uses fb_append_extra_logo().

So there's a relationship already between logo and fbdev/core, that's why
I wondered if would make sense to also move drivers/video/logo.c to have
both functions in there.

Fair enough. I was looking for references to struct fb_info in the logo code and found none. Sam's suggestion to move the remaining code from fbdev to logo/ might be the way to go.

If we ever get that DRM boot-up client, it might want to use the logo as well. Hence, it needs to be unrelated to fbdev.

Best regards
Thomas

Yes, as noted drivers/video/console/newport_con.c also uses fb_find_logo()
but the only other user of that in drivers/video/fbdev/core/fbmem.c.

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)