Re: [PATCH] video: logo: LOGO should depend on FB_CORE i.s.o. FB
From: Sam Ravnborg <hidden>
Date: 2023-07-25 17:56:47
Also in:
dri-devel, lkml
From: Sam Ravnborg <hidden>
Date: 2023-07-25 17:56:47
Also in:
dri-devel, lkml
Hi Javier,
quoted
quoted
quoted
menuconfig LOGO bool "Bootup logo" - depends on FB || SGI_NEWPORT_CONSOLE + depends on FB_CORE || SGI_NEWPORT_CONSOLE help Enable and select frame buffer bootup logos.Should then move this option to drivers/video/fbdev/core/Kconfig ?No, all logo options are in their own file.Yes. I meant to move drivers/video/logo/ to drivers/fbdev/core/logo and to source its Kconfig from drivers/fbdev/core/Kconfig, since it now depends on FB_CORE. But I see now that it also depends on SGI_NEWPORT_CONSOLE, so having those in drivers/video/logo makes sense indeed.
The SGI_NEWPORT_CONSOLE should be replaced by some ifdef in the newport_con.c code - to do what other drivers do. But thats for another day. Sam