Hi

Am 25.07.23 um 18:50 schrieb Javier Martinez Canillas:

Geert Uytterhoeven [off-list ref] writes:

quoted

Hi Javier,

On Tue, Jul 25, 2023 at 6:07 PM Javier Martinez Canillas
[off-list ref] wrote:

quoted

Geert Uytterhoeven [off-list ref] writes:

quoted

If CONFIG_FB_CORE=y but CONFIG_FB=n, the frame buffer bootup logos can
no longer be enabled.  Fix this by making CONFIG_LOGO depend on
CONFIG_FB_CORE instead of CONFIG_FB, as there is no good reason for the
logo code to depend on the presence of real frame buffer device drivers.

Indeed.

quoted

Fixes: 55bffc8170bb5813 ("fbdev: Split frame buffer support in FB and FB_CORE symbols")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
  drivers/video/Kconfig      | 2 +-
  drivers/video/logo/Kconfig | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index e5b1cc54cafa10d5..b694d7669d3200b1 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig

@@ -63,7 +63,7 @@ if VT
       source "drivers/video/console/Kconfig"
  endif

-if FB || SGI_NEWPORT_CONSOLE
+if FB_CORE || SGI_NEWPORT_CONSOLE
       source "drivers/video/logo/Kconfig"

  endif

diff --git a/drivers/video/logo/Kconfig b/drivers/video/logo/Kconfig
index 6d6f8c08792dc897..b7d94d1dd1585a84 100644
--- a/drivers/video/logo/Kconfig
+++ b/drivers/video/logo/Kconfig

@@ -5,7 +5,7 @@

  menuconfig LOGO
       bool "Bootup logo"
-     depends on FB || SGI_NEWPORT_CONSOLE
+     depends on FB_CORE || SGI_NEWPORT_CONSOLE
       help
         Enable and select frame buffer bootup logos.

Should then move this option to drivers/video/fbdev/core/Kconfig ?

No, all logo options are in their own file.

Yes. I meant to move drivers/video/logo/ to drivers/fbdev/core/logo and to
source its Kconfig from drivers/fbdev/core/Kconfig, since it now depends
on FB_CORE.

No, please rather leave it where it is. There's no code dependencies to 
the fbdev core; it merely depends on the Kconfig token.

Best regards
Thomas

But I see now that it also depends on SGI_NEWPORT_CONSOLE, so having those
in drivers/video/logo makes sense indeed.

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)