Thread (36 messages) 36 messages, 8 authors, 2023-07-12

Re: [PATCH 09/17] auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers

From: Miguel Ojeda <hidden>
Date: 2023-07-10 14:24:37
Also in: amd-gfx, dri-devel, kvm, linux-arm-kernel, linux-hyperv, linux-input, linux-media, linux-omap, linux-sh, linux-staging, linuxppc-dev, lkml

On Mon, Jul 10, 2023 at 3:01 PM Thomas Zimmermann [off-list ref] wrote:
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct
fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do
not set it.
`framebuffer_alloc()` does indeed use `kzalloc()`, but the docs do not
mention the zeroing. Should that guarantee be documented?
Flags should signal differences from the default values. After cleaning
up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed.
occurences -> occurrences

can -> will maybe? Since the intention of the patch series is to
remove it (them) altogether).

Thanks!

Cheers,
Miguel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help