Re: [PATCH 08/17] arch/sh: Do not assign FBINFO_FLAG_DEFAULT to fb_videomode.flag
From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Date: 2023-07-10 13:59:45
Also in:
amd-gfx, dri-devel, kvm, linux-arm-kernel, linux-hyperv, linux-input, linux-media, linux-omap, linux-sh, linux-staging, linuxppc-dev, lkml
Hi Thomas! On Mon, 2023-07-10 at 15:52 +0200, Thomas Zimmermann wrote:
quoted
I would argue that the current code is more readable that your proposed change. I agree that it's a no-op, but code is not just about functionality but also readability, isn't it?I won't argue with that, but the flag itself is wrong. FBINFO_FLAG_DEFAULT is/was for struct fb_info.flags. You have struct fb_videomode.flag. The valid flags for this field are at [1]. If anything, the field could be initialized to FB_MODE_IS_UNKNOWN, which has the same value. [1] https://elixir.bootlin.com/linux/latest/source/include/linux/fb.h#L681
FB_MODE_IS_UNKNOWN sounds very reasonable to me. Would you agree using that instead?
quoted
Also, I prefer "sh:" as the architecture prefix, not "arch/sh:".Ok.
Thanks. Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer `. `' Physicist `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913