Re: [PATCH 10/17] hid/picolcd: Remove flag FBINFO_FLAG_DEFAULT from fbdev driver
From: Benjamin Tissoires <hidden>
Date: 2023-07-10 13:09:09
Also in:
amd-gfx, dri-devel, kvm, linux-arm-kernel, linux-hyperv, linux-input, linux-media, linux-omap, linux-sh, linux-staging, linuxppc-dev, lkml
On Mon, Jul 10, 2023 at 3:01 PM Thomas Zimmermann [off-list ref] wrote:
The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do not set it. Flags should signal differences from the default values. After cleaning up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed. Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Cc: "Bruno Prémont" <bonbons@linux-vserver.org> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <redacted>
Acked-by: Benjamin Tissoires <redacted> Feel free to take this through the DRI tree (or any other that handles FB) with the rest of the series if you want. Cheers, Benjamin
quoted hunk ↗ jump to hunk
--- drivers/hid/hid-picolcd_fb.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c index dabcd054dad9..d726aaafb146 100644 --- a/drivers/hid/hid-picolcd_fb.c +++ b/drivers/hid/hid-picolcd_fb.c@@ -527,7 +527,6 @@ int picolcd_init_framebuffer(struct picolcd_data *data) info->var = picolcdfb_var; info->fix = picolcdfb_fix; info->fix.smem_len = PICOLCDFB_SIZE*8; - info->flags = FBINFO_FLAG_DEFAULT; fbdata = info->par; spin_lock_init(&fbdata->lock); --2.41.0