Re: [PATCH 6/6] i2c: Make remove callback return void
From: Christophe Leroy <hidden>
Date: 2022-06-29 07:55:50
Also in:
chrome-platform, dri-devel, linux-arm-kernel, linux-crypto, linux-gpio, linux-hwmon, linux-i2c, linux-iio, linux-input, linux-integrity, linux-media, linux-mediatek, linux-pm, linux-pwm, linux-rtc, linux-serial, linux-staging, linux-watchdog, linuxppc-dev, netdev, platform-driver-x86
Possibly related (same subject, not in this thread)
- 2022-07-06 · Re: [PATCH 6/6] i2c: Make remove callback return void · Uwe Kleine-König <hidden>
- 2022-07-06 · Re: [PATCH 6/6] i2c: Make remove callback return void · Vladimir Oltean <olteanv@gmail.com>
- 2022-07-05 · Re: [PATCH 6/6] i2c: Make remove callback return void · Uwe Kleine-König <hidden>
- 2022-07-05 · Re: [PATCH 6/6] i2c: Make remove callback return void · Jean Delvare <hidden>
- 2022-06-29 · Re: [PATCH 6/6] i2c: Make remove callback return void · Luca Ceresoli <luca@lucaceresoli.net>
Le 29/06/2022 à 09:23, Uwe Kleine-König a écrit :
Hello, [I dropped nearly all individuals from the Cc: list because various bounces reported to be unhappy about the long (logical) line.]
Good idea, even patchwork made a mess of it, see https://patchwork.ozlabs.org/project/linuxppc-dev/patch/20220628140313.74984-7-u.kleine-koenig@pengutronix.de/
On Wed, Jun 29, 2022 at 03:03:54PM +0800, Jeremy Kerr wrote:quoted
Looks good - just one minor change for the mctp-i2c driver, but only worthwhile if you end up re-rolling this series for other reasons:quoted
-static int mctp_i2c_remove(struct i2c_client *client) +static void mctp_i2c_remove(struct i2c_client *client) { struct mctp_i2c_client *mcli = i2c_get_clientdata(client); struct mctp_i2c_dev *midev = NULL, *tmp = NULL;@@ -1000,7 +1000,6 @@ static int mctp_i2c_remove(struct i2c_client *client) mctp_i2c_free_client(mcli); mutex_unlock(&driver_clients_lock); /* Callers ignore return code */ - return 0; }The comment there no longer makes much sense, I'd suggest removing that too.Yeah, that was already pointed out to me in a private reply. It's already fixed in https://git.pengutronix.de/cgit/ukl/linux/log/?h=i2c-remove-voidquoted
Either way: Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au>Added to my tree, too. Thanks Uwe