Re: [PATCH 6/6] i2c: Make remove callback return void
From: Javier Martinez Canillas <javierm@redhat.com>
Date: 2022-06-29 07:37:18
Also in:
chrome-platform, dri-devel, linux-arm-kernel, linux-crypto, linux-gpio, linux-hwmon, linux-i2c, linux-iio, linux-input, linux-integrity, linux-media, linux-mediatek, linux-pm, linux-pwm, linux-rtc, linux-serial, linux-staging, linux-watchdog, linuxppc-dev, netdev, platform-driver-x86
Possibly related (same subject, not in this thread)
- 2022-07-06 · Re: [PATCH 6/6] i2c: Make remove callback return void · Uwe Kleine-König <hidden>
- 2022-07-06 · Re: [PATCH 6/6] i2c: Make remove callback return void · Vladimir Oltean <olteanv@gmail.com>
- 2022-07-05 · Re: [PATCH 6/6] i2c: Make remove callback return void · Uwe Kleine-König <hidden>
- 2022-07-05 · Re: [PATCH 6/6] i2c: Make remove callback return void · Jean Delvare <hidden>
- 2022-06-29 · Re: [PATCH 6/6] i2c: Make remove callback return void · Luca Ceresoli <luca@lucaceresoli.net>
On 6/29/22 09:23, Uwe Kleine-König wrote:
Hello, [I dropped nearly all individuals from the Cc: list because various bounces reported to be unhappy about the long (logical) line.]
Yes, it also bounced for me when I tried to reply earlier today.
quoted hunk ↗ jump to hunk
diff --git a/drivers/gpu/drm/solomon/ssd130x-i2c.c b/drivers/gpu/drm/solomon/ssd130x-i2c.c index 1e0fcec7be47..ddfa0bb5d9c9 100644 --- a/drivers/gpu/drm/solomon/ssd130x-i2c.c +++ b/drivers/gpu/drm/solomon/ssd130x-i2c.c@@ -39,13 +39,11 @@ static int ssd130x_i2c_probe(struct i2c_client *client) return 0; } -static int ssd130x_i2c_remove(struct i2c_client *client) +static void ssd130x_i2c_remove(struct i2c_client *client) { struct ssd130x_device *ssd130x = i2c_get_clientdata(client); ssd130x_remove(ssd130x); - - return 0; } static void ssd130x_i2c_shutdown(struct i2c_client *client)
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat