Thread (6 messages) 6 messages, 2 authors, 2021-10-01

Re: [PATCH] backlight: hx8357: Add SPI device ID table

From: Daniel Thompson <hidden>
Date: 2021-10-01 14:20:17
Also in: dri-devel

On Mon, Sep 27, 2021 at 02:30:56PM +0100, Mark Brown wrote:
On Mon, Sep 27, 2021 at 02:24:17PM +0100, Daniel Thompson wrote:
quoted
In that case what is the point of including unconsumed driver data? Most
DT centric drivers that included this for modalias reasons leave it
NULL.
It's mainly there because it's generated fairly mechanically from the OF
ID table - there's no great reason for it to be there while all
instantiation is done via DT.
Ok. If there's no plan to change the driver to pick it up from the table then
let's remove the redundant values. They just make it look like somebody forgot
something in the probe method (instead of it being a deliberate choice).


Daniel.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help