Re: [PATCH] backlight: hx8357: Add SPI device ID table
From: Daniel Thompson <hidden>
Date: 2021-09-27 09:42:06
Also in:
dri-devel
On Wed, Sep 22, 2021 at 04:10:14PM +0100, Mark Brown wrote:
quoted hunk ↗ jump to hunk
Currently autoloading for SPI devices does not use the DT ID table, it uses SPI modalises. Supporting OF modalises is going to be difficult if not impractical, an attempt was made but has been reverted, so ensure that module autoloading works for this driver by adding a SPI device ID table. Fixes: 96c8395e2166 ("spi: Revert modalias changes") Signed-off-by: Mark Brown <broonie@kernel.org> --- drivers/video/backlight/hx8357.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+)diff --git a/drivers/video/backlight/hx8357.c b/drivers/video/backlight/hx8357.c index 9b50bc96e00f..c64b1fbe027f 100644 --- a/drivers/video/backlight/hx8357.c +++ b/drivers/video/backlight/hx8357.c@@ -565,6 +565,19 @@ static struct lcd_ops hx8357_ops = { .get_power = hx8357_get_power, }; +static const struct spi_device_id hx8357_spi_ids[] = { + { + .name = "hx8357", + .driver_data = (kernel_ulong_t)hx8357_lcd_init,
Based on this I had expected to find spi_get_device_id() and a ->driver_data somewhere in this patch. Where will this .driver_data be consumed? Daniel.
quoted hunk ↗ jump to hunk
+ }, + { + .name = "hx8369", + .driver_data = (kernel_ulong_t)hx8369_lcd_init, + }, + {}, +}; +MODULE_DEVICE_TABLE(spi, hx8357_spi_ids); + static const struct of_device_id hx8357_dt_ids[] = { { .compatible = "himax,hx8357",@@ -672,6 +685,7 @@ static struct spi_driver hx8357_driver = { .name = "hx8357", .of_match_table = hx8357_dt_ids, }, + .id_table = hx8357_spi_ids, }; module_spi_driver(hx8357_driver);-- 2.20.1