On Mon, Sep 27, 2021 at 12:47:27PM +0100, Mark Brown wrote:

On Mon, Sep 27, 2021 at 10:42:00AM +0100, Daniel Thompson wrote:

quoted

Based on this I had expected to find spi_get_device_id() and a ->driver_data
somewhere in this patch.

quoted

Where will this .driver_data be consumed? 

It will never be consumed unless someone writes a board file - the
runtime match will still happen based on the DT compatible, this is only
there for the modalias.

Ok... so I'm not going mad.

In that case what is the point of including unconsumed driver data? Most
DT centric drivers that included this for modalias reasons leave it
NULL.

I reviewed quite a few drivers this morning and I haven't seen a single
one that includes unreachable driver data in this manner. Unless there's
a good reason I'd prefer backlight to follow the prior art!


Daniel.