Thread (31 messages) read the whole thread 31 messages, 6 authors, 2017-12-03

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

From: Julia Lawall <hidden>
Date: 2017-11-28 09:29:11
Also in: dri-devel, kernel-janitors, linux-omap, lkml


On Tue, 28 Nov 2017, SF Markus Elfring wrote:
quoted
How many times have I told you to include the reason for
your patches in your proposed commit message?
It might be useful to look again.

quoted
Too often.
I answered this feedback to some degree.

quoted
Many people do not know that a generic kmalloc does a
dump_stack() on OOM.
This is another interesting information, isn't it?

It is expected that the function “devm_kzalloc” has got a similar property.

You don't have to expect this.  Go look at the definition of devm_kzalloc
and see whether it has the property or not.
For which hardware and software combinations would you like to see
facts there?
This is not for Joe to decide, it's for the person who receives the patch
to decide.  You could start with the ones for which the code actually
compiles, using the standard make file and no special options, and a
recent version of gcc.

julia
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help