Thread (31 messages) 31 messages, 6 authors, 2017-12-03

Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions

flat view

From: Joe Perches <joe@perches.com>
Date: 2017-11-28 08:04:11
Also in: dri-devel, kernel-janitors, linux-omap, lkml

On Tue, 2017-11-28 at 08:41 +0100, SF Markus Elfring wrote:
quoted
quoted
It seems that I got no responses so far for clarification requests
according to the documentation in a direction I hoped for.
That's because you are pretty unresponsive to direction.
From which places did you get this impression?
How many times have I told you to include the reason for
your patches in
your proposed commit message?  Too often.

For instance, specific to this patch:

Many people do not know that a generic kmalloc does a
dump_stack() on OOM.  That information should be part
of the commit message.

Also removing the printk code reduces overall code size.
The actual size reduction should be described in the
commit message too.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help