Re: [PATCH 06/23] ARM: OMAP: add OMAP5 DSI muxing

From
Tomi Valkeinen <hidden>
Date
2014-04-25 11:18:08
Also in
linux-arm-kernel, linux-omap
Reply to
Archit Taneja, 2014-04-25
On 25/04/14 14:11, Archit Taneja wrote:
Hi,

On Thursday 24 April 2014 03:47 PM, Tomi Valkeinen wrote:
quoted
Add support to set OMAP5 DSI pin muxing.

Signed-off-by: Tomi Valkeinen <redacted>
Cc: Tony Lindgren <tony@atomide.com>
---
  arch/arm/mach-omap2/display.c | 35 ++++++++++++++++++++++++++++++++++-
  1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/display.c
b/arch/arm/mach-omap2/display.c
index 16d33d831287..974461441fc3 100644
--- a/arch/arm/mach-omap2/display.c
+++ b/arch/arm/mach-omap2/display.c
@@ -137,11 +137,42 @@ static int omap4_dsi_mux_pads(int dsi_id,
unsigned lanes)
      return 0;
  }

+#define CONTROL_PAD_BASE    0x4A002800
+#define CONTROL_DSIPHY        0x614
+
I guess this is something we can move to our driver, and use sysconf to
get the register from DT.
I just copied the same method as used for OMAP4.

I guess sysconf is an option. But I really dislike the idea of moving
omap control module code to a display driver... I'm not sure what other
options we have, though. Maybe an OMAP DSI specific pinctrl driver?

 Tomi

Attachments

Thread (45 messages) 45 messages, 4 authors, last reply 2014-05-02
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help