Thread (45 messages) 45 messages, 4 authors, 2014-05-02
STALE4429d

Re: [PATCH 11/23] ARM: dts: omap5-uevm.dts: add tca6424a

From: Sergei Shtylyov <hidden>
Date: 2014-04-24 16:53:29
Also in: linux-arm-kernel, linux-omap

Hello.

On 04/24/2014 06:33 PM, Tomi Valkeinen wrote:
quoted
quoted
omap5-uevm has a tca6424a I/O expander. Add it to the .dts file.
quoted
quoted
Signed-off-by: Tomi Valkeinen <redacted>
Cc: Tony Lindgren <tony@atomide.com>
---
   arch/arm/boot/dts/omap5-uevm.dts | 7 +++++++
   1 file changed, 7 insertions(+)
quoted
quoted
diff --git a/arch/arm/boot/dts/omap5-uevm.dts
b/arch/arm/boot/dts/omap5-uevm.dts
index 3b99ec25b748..9e7581eaeb23 100644
--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts
@@ -434,6 +434,13 @@
       pinctrl-0 = <&i2c5_pins>;

       clock-frequency = <400000>;
+
+    tca6424a: tca6424a@22 {
quoted
    The ePAPR standard [1] says: "The name of a node should be somewhat
generic,
reflecting the function of the device and not its precise programming
model.
If appropriate, the name should be one of the following choices:
[...]
    - gpio;"
Right. I wonder what the name should be... "gpio" is out, as the name
should be more specific.
    No, it's not out. The name should be "gpio@22", I think it would be unique.
We already have gpio1-8, which are the gpio
banks from the SoC.
    I don't understand why you are indexing the names while you probably have 
the address part after @ that makes them unique already.
  Tomi
WBR, Sergei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help