Re: [PATCH 11/23] ARM: dts: omap5-uevm.dts: add tca6424a

On 24/04/14 16:49, Sergei Shtylyov wrote:

Hello.

On 24-04-2014 14:17, Tomi Valkeinen wrote:

quoted

omap5-uevm has a tca6424a I/O expander. Add it to the .dts file.

quoted

Signed-off-by: Tomi Valkeinen <redacted>
Cc: Tony Lindgren <tony@atomide.com>
---
  arch/arm/boot/dts/omap5-uevm.dts | 7 +++++++
  1 file changed, 7 insertions(+)

quoted

diff --git a/arch/arm/boot/dts/omap5-uevm.dts

b/arch/arm/boot/dts/omap5-uevm.dts
index 3b99ec25b748..9e7581eaeb23 100644

--- a/arch/arm/boot/dts/omap5-uevm.dts
+++ b/arch/arm/boot/dts/omap5-uevm.dts

@@ -434,6 +434,13 @@
      pinctrl-0 = <&i2c5_pins>;

      clock-frequency = <400000>;
+
+    tca6424a: tca6424a@22 {

   The ePAPR standard [1] says: "The name of a node should be somewhat
generic,
reflecting the function of the device and not its precise programming
model.
If appropriate, the name should be one of the following choices:
[...]
   - gpio;"

Right. I wonder what the name should be... "gpio" is out, as the name
should be more specific. We already have gpio1-8, which are the gpio
banks from the SoC. It could be 'gpio9', but that makes it sound it's
just one more SoC gpio bank. 'gpio-expander1'?

 Tomi