Thread (5 messages) 5 messages, 3 authors, 2013-09-26

Re: [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init()

flat view

From: Tomi Valkeinen <hidden>
Date: 2013-09-26 09:43:43
Also in: kernel-janitors

On 25/09/13 11:54, Dan Carpenter wrote:
quoted hunk ↗ jump to hunk
"rval" needs to be signed for the error handling to work.

Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index c63f918..65392f9 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c
@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip)
 /* interrupt handling */
 static void lm3630a_delayed_func(struct work_struct *work)
 {
-	unsigned int rval;
+	int rval;
 	struct lm3630a_chip *pchip;
 
 	pchip = container_of(work, struct lm3630a_chip, work.work);
There's no drivers/video/backlight/lm3630a_bl.c in v3.12. Which kernel
is this for?

 Tomi

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help