Re: [patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init()
flat view
From: Jingoo Han <hidden>
Date: 2013-09-25 09:30:31
Also in:
kernel-janitors
On Wednesday, September 25, 2013 5:55 PM, Dan Carpenter wrote:
"rval" needs to be signed for the error handling to work. Signed-off-by: Dan Carpenter <redacted>
CC'ed Andrew Morton, Daniel Jeong, Acked-by: Jingoo Han <redacted>
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index c63f918..65392f9 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip) /* interrupt handling */ static void lm3630a_delayed_func(struct work_struct *work) { - unsigned int rval; + int rval; struct lm3630a_chip *pchip; pchip = container_of(work, struct lm3630a_chip, work.work);