[patch 1/2] backlight: lm3630: signedness bug in lm3630a_chip_init()
flat view
STALE4761d
REVIEWED: 1 (0M)
From: Dan Carpenter <hidden>
Date: 2013-09-25 09:35:33
Also in:
kernel-janitors
Subsystem:
backlight class/subsystem, framebuffer layer, the rest · Maintainers:
Lee Jones, Daniel Thompson, Jingoo Han, Helge Deller, Linus Torvalds
1 review trailer.
"rval" needs to be signed for the error handling to work. Signed-off-by: Dan Carpenter <redacted> Acked-by: Jingoo Han <redacted>
diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c
index c63f918..65392f9 100644
--- a/drivers/video/backlight/lm3630a_bl.c
+++ b/drivers/video/backlight/lm3630a_bl.c@@ -105,7 +105,7 @@ static int lm3630a_chip_init(struct lm3630a_chip *pchip) /* interrupt handling */ static void lm3630a_delayed_func(struct work_struct *work) { - unsigned int rval; + int rval; struct lm3630a_chip *pchip; pchip = container_of(work, struct lm3630a_chip, work.work); --
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html