Re: [PATCH] OMAPDSS: Check if RPM enabled before trying to change state

On 25 June 2012 17:35, Grazvydas Ignotas [off-list ref] wrote:

On Mon, Jun 25, 2012 at 9:20 AM, Tomi Valkeinen [off-list ref] wrote:

quoted

On Sat, 2012-06-23 at 13:36 +0530, jaswinder.singh@linaro.org wrote:

quoted

 Currenlty HDMI fails to come up in the suspend-resume path.
This patch helps that real-world scenario.

What is the problem there? It'd be good to explain the problem in the
patch description. Does the pm_runtime_get return -EACCES?

On slightly different but related issue, currently OMAPDSS always
spits lots of backtraces when it's compiled without CONFIG_PM_RUNTIME,
because pm_runtime_put* always return -ENOSYS without
CONFIG_PM_RUNTIME. So something like this patch proposes is needed, or
maybe WARN_ON should check for -ENOSYS, I don't know..

I didn't check, but this patch should already fix that I think ?

IMHO, for omapdss, we need not differentiate between -ENOSYS and
-EACCESS because anyway the ultimate functions dispc_runtime_resume()
and dispc_runtime_suspend()  can't report failure (they always return
0).

-j