Thread (39 messages) 39 messages, 6 authors, 2012-06-28

Re: [PATCH] OMAPDSS: Check if RPM enabled before trying to change state

flat view

From: Tomi Valkeinen <hidden>
Date: 2012-06-25 06:20:21
Also in: linux-omap

On Sat, 2012-06-23 at 13:36 +0530, jaswinder.singh@linaro.org wrote:
From: Jassi Brar <redacted>

If the runtime PM of the device is disabled (for example in resume from
suspend path), it doesn't make sense to attempt pm_runtime_get/put, esp
when their return values affect the control flow path.
This looks strange. When the driver does pm_runtime_get() it expects the
HW to be functional and registers accessible. If we just skip the
pm_runtime_get(), how can the code work?
Signed-off-by: Jassi Brar <redacted>
---

 Currenlty HDMI fails to come up in the suspend-resume path.
This patch helps that real-world scenario.
What is the problem there? It'd be good to explain the problem in the
patch description. Does the pm_runtime_get return -EACCES?

 Tomi

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help