Re: [PATCH] OMAPDSS: Check if RPM enabled before trying to change state

From
Tomi Valkeinen <hidden>
Date
2012-06-25 12:30:59
Also in
linux-omap
Reply to
Grazvydas Ignotas, 2012-06-25
On Mon, 2012-06-25 at 15:05 +0300, Grazvydas Ignotas wrote:
On Mon, Jun 25, 2012 at 9:20 AM, Tomi Valkeinen [off-list ref] wrote:
quoted
On Sat, 2012-06-23 at 13:36 +0530, jaswinder.singh@linaro.org wrote:
quoted
 Currenlty HDMI fails to come up in the suspend-resume path.
This patch helps that real-world scenario.
What is the problem there? It'd be good to explain the problem in the
patch description. Does the pm_runtime_get return -EACCES?
On slightly different but related issue, currently OMAPDSS always
spits lots of backtraces when it's compiled without CONFIG_PM_RUNTIME,
because pm_runtime_put* always return -ENOSYS without
CONFIG_PM_RUNTIME. So something like this patch proposes is needed, or
maybe WARN_ON should check for -ENOSYS, I don't know..
Hmm. I guess I'm missing some understanding about runtime PM. omapdss
uses runtime PM to enable the underlying DSS hardware. If there's no
runtime PM, how does the driver work? Or is it the job of
hwmod/omap_device to keep all the hardware always enabled if runtime PM
is not compiled in?

 Tomi

Attachments

Thread (39 messages) 39 messages, 6 authors, 2012-06-28
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help