Re: [PATCH 1/4] mfd: add LM3533 lighting-power core driver
flat view
From: Mark Brown <hidden>
Date: 2012-04-26 12:41:34
Also in:
lkml
On Fri, Apr 20, 2012 at 05:30:23PM +0200, Johan Hovold wrote:
quoted hunk ↗ jump to hunk
+static int __lm3533_read(struct lm3533 *lm3533, u8 reg, u8 *val) +{ + int ret; + + ret = lm3533->read(lm3533, reg, val); + if (ret < 0) {
Looks like you could save a bunch of code by using regmap for the register I/O. This would also give you access to the cache and diagnostic infrastructure it has.