Re: [PATCH 4/4] ARM: PXA: PXAFB: don't disable controller on cpufreq
DORMANTno replies
From: Eric Miao <hidden>
Date: 2011-03-16 13:16:42
Also in:
linux-arm-kernel
Applied. On Fri, Mar 11, 2011 at 5:20 PM, Vasily Khoruzhick [off-list ref] wrote:
quoted hunk ↗ jump to hunk
It's not safe to disable controller if overlay(s) is enabled (results in system hang). So we avoid to disable controller in this case. Userspace should choose proper governor to avoid freq changing when overlay is in use, otherwise LCD may blink. Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> --- drivers/video/pxafb.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-)diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c index a3bdcc1..a2e5b51 100644 --- a/drivers/video/pxafb.c +++ b/drivers/video/pxafb.c@@ -1648,7 +1648,8 @@ pxafb_freq_transition(struct notifier_block *nb, unsigned long val, void *data)switch (val) { case CPUFREQ_PRECHANGE: - set_ctrlr_state(fbi, C_DISABLE_CLKCHANGE); + if (!fbi->overlay[0].usage && !fbi->overlay[1].usage) + set_ctrlr_state(fbi, C_DISABLE_CLKCHANGE); break; case CPUFREQ_POSTCHANGE: -- 1.7.4.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel