Re: [PATCH] ARM: PXA: Make PXA27x/PXA3xx overlay actually work

On Tue, Feb 15, 2011 at 9:51 PM, Vasily Khoruzhick [off-list ref] wrote:

On Tuesday 15 February 2011 15:36:07 you wrote:

quoted

Then maybe in this way? (I'd rather keep this bit in overlay specific
code, and make it valid not only to pxa27x)

@@ -925,6 +925,8 @@ static int __devinit pxafb_overlay_init(struct

pxafb_info *fbi)

        /* place overlay(s) on top of base */
        fbi->lccr0 |= LCCR0_OUC;
+       lcd_writel(fbi, LCCR0, fbi->lccr0 & ~LCCR0_ENB);
+
        pr_info("PXA Overlay driver loaded successfully!\n");
        return 0;

I tried it, it doesn't work that way (I got garbage on screen). Maybe it's not
right time to modify LCCR0 reg?

I guess that's because OUC bit needs to be set when the panel is
not enabled. But re-enabling here is a bit hackish as well.

I don't mind move the code a bit, but can we separate this change
into another patch from the rest?

Thanks
- eric