Re: [PATCH v2 3/3] ARM: PXA: PXAFB: Fix typo in ypos assignment
STALE5681d
REVIEWED: 1 (0M)
From: Marek Vasut <hidden>
Date: 2011-02-20 18:47:24
Also in:
linux-arm-kernel
1 review trailer.
On Sunday 20 February 2011 16:02:27 Vasily Khoruzhick wrote:
Sascha Hauer [off-list ref] pointed that ypos takes value of xpos due to typo.
Looks good, Acked-by: Marek Vasut <redacted>
quoted hunk ↗ jump to hunk
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com> --- drivers/video/pxafb.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c index 54a9ab8..80ea7e6 100644 --- a/drivers/video/pxafb.c +++ b/drivers/video/pxafb.c@@ -766,7 +766,7 @@ static int overlayfb_check_var(struct fb_var_screeninfo*var, int xpos, ypos, pfor, bpp; xpos = NONSTD_TO_XPOS(var->nonstd); - ypos = NONSTD_TO_XPOS(var->nonstd); + ypos = NONSTD_TO_YPOS(var->nonstd); pfor = NONSTD_TO_PFOR(var->nonstd); bpp = pxafb_var_to_bpp(var);@@ -864,7 +864,7 @@ static int overlayfb_set_par(struct fb_info *info) bpp = pxafb_var_to_bpp(var); xpos = NONSTD_TO_XPOS(var->nonstd); - ypos = NONSTD_TO_XPOS(var->nonstd); + ypos = NONSTD_TO_YPOS(var->nonstd); pfor = NONSTD_TO_PFOR(var->nonstd); ofb->control[0] = OVLxC1_PPL(var->xres) | OVLxC1_LPO(var->yres) |