Thread (14 messages) 14 messages, 4 authors, 2009-06-03

Re: [PATCH 05/10] ARM: OMAP1: Make 770 LCD work, v3

From: Tony Lindgren <tony@atomide.com>
Date: 2009-05-28 21:03:04
Also in: linux-omap

* Tony Lindgren [off-list ref] [090528 12:12]:
* Andrew de Quincey [off-list ref] [090528 11:44]:
quoted
Quoting Tony Lindgren [off-list ref]:
quoted
* Andrew de Quincey [off-list ref] [090525 09:41]:
quoted
Quoting Andrew de Quincey [off-list ref]:
quoted
Quoting Russell King - ARM Linux [off-list ref]:
quoted
On Tue, May 19, 2009 at 04:37:32PM -0700, Tony Lindgren wrote:
quoted
Make 770 LCD work by passing the clock from platform data.
Also remove the old unused functions.
I don't like this - because its passing struct clk's through platform
data.  That's not how things are supposed to work.

The way PXA solves this problem is to have clock aliases - see
clk_add_alias().
Interesting idea - I now have a prototype patch implementing this,
which I'll send when I get home (otherwise it would be an "it
compiles" "test" :)

There isn't a common definition of clk_add_alias() though - that
symbol is defined in arch/arm/mach-pxa/clock.c, so I had to copy it
into arch/arm/plat-omap/clock.c
Attached is a patch implementing this method. I don't like the
duplication of the clk_alias code, but I imagine that could be resolved
if this method was chosen....
Andrew, can you please reply with your Signed-off-by?
Sure - sorry I was holding off in case there were any comments on the  
method...
I added a note about maybe moving the clk_add_alias() to
arch/arm/common/clkdev.c later.

Also noticed there were some whitespace errors, updated version below.
One more time with clk_add_alias() in a separate patch.

Tony

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help