Re: [PATCH 05/10] ARM: OMAP1: Make 770 LCD work
From: Andrew de Quincey <hidden>
Date: 2009-05-25 13:21:28
Also in:
linux-omap
From: Andrew de Quincey <hidden>
Date: 2009-05-25 13:21:28
Also in:
linux-omap
Quoting Russell King - ARM Linux [off-list ref]:
On Tue, May 19, 2009 at 04:37:32PM -0700, Tony Lindgren wrote:quoted
Make 770 LCD work by passing the clock from platform data. Also remove the old unused functions.I don't like this - because its passing struct clk's through platform data. That's not how things are supposed to work. The way PXA solves this problem is to have clock aliases - see clk_add_alias().
Interesting idea - I now have a prototype patch implementing this, which I'll send when I get home (otherwise it would be an "it compiles" "test" :) There isn't a common definition of clk_add_alias() though - that symbol is defined in arch/arm/mach-pxa/clock.c, so I had to copy it into arch/arm/plat-omap/clock.c