Thread (14 messages) 14 messages, 4 authors, 2009-06-03

Re: [PATCH 05/10] ARM: OMAP1: Make 770 LCD work

From: Andrew de Quincey <hidden>
Date: 2009-05-25 16:40:55
Also in: linux-omap

Quoting Andrew de Quincey [off-list ref]:
Quoting Russell King - ARM Linux [off-list ref]:
quoted
On Tue, May 19, 2009 at 04:37:32PM -0700, Tony Lindgren wrote:
quoted
Make 770 LCD work by passing the clock from platform data.
Also remove the old unused functions.
I don't like this - because its passing struct clk's through platform
data.  That's not how things are supposed to work.

The way PXA solves this problem is to have clock aliases - see
clk_add_alias().
Interesting idea - I now have a prototype patch implementing this,  
which I'll send when I get home (otherwise it would be an "it  
compiles" "test" :)

There isn't a common definition of clk_add_alias() though - that  
symbol is defined in arch/arm/mach-pxa/clock.c, so I had to copy it  
into arch/arm/plat-omap/clock.c
Attached is a patch implementing this method. I don't like the  
duplication of the clk_alias code, but I imagine that could be  
resolved if this method was chosen....

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help