On Wed, Jul 16, 2008 at 5:38 PM, Russell King - ARM Linux
[off-list ref] wrote:
On Wed, Jul 16, 2008 at 01:59:42AM -0700, Jaya Kumar wrote:
quoted
On Wed, Jul 16, 2008 at 12:00 AM, eric miao [off-list ref] wrote:
quoted
On Sun, Jul 13, 2008 at 9:26 PM, Jaya Kumar [off-list ref] wrote:
quoted
These changes are to make it possible for a secondary driver to share the
pxafb framebuffer. The changes include:
- adding clkdev entry in pxafb_mach_info so that a driver can pass in the
correct struct device owner for the LCDCLK.
Is it possible that LCDCLK being requested by device other than
pxa_device_fb?? Could you give an example and we may work out
a better solution.
You're right. I think LCDCLK is only ever requested by pxa_device_fb.
I see now that instead of doing:
- fbi->clk = clk_get(dev, "LCDCLK");
+ fbi->clk = clk_get(inf->clkdev, "LCDCLK");
a better solution would be to directly use pxa_device_fb:
- fbi->clk = clk_get(dev, "LCDCLK");
+ fbi->clk = clk_get(pxa_device_fb.dev, "LCDCLK");
and then I can avoid doing the clkdev ugliness.
PXA devices (intentionally) aren't exported. Nor are they going to be,
so the above will fail if built as a module.
Ah... I think this may be the cause of all my troubles. I've been
trying to support am200epd working as a module, and allow it to rmmod
cleanly, hence the inability to use pxa_device_fb through
set_pxa_fb_info. If module support isn't important then I can happily
take out unload support from am200epd and probably can then use
set_pxa_fb_info and also reduce complexity in other parts of the
metronomefb, am200epd, pxafb code.
Thanks,
jaya
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/