On Wed, Jul 16, 2008 at 12:00 AM, eric miao [off-list ref] wrote:

On Sun, Jul 13, 2008 at 9:26 PM, Jaya Kumar [off-list ref] wrote:

quoted

These changes are to make it possible for a secondary driver to share the
pxafb framebuffer. The changes include:
- adding clkdev entry in pxafb_mach_info so that a driver can pass in the
 correct struct device owner for the LCDCLK.

Is it possible that LCDCLK being requested by device other than
pxa_device_fb?? Could you give an example and we may work out
a better solution.

Hi Eric,

You're right. I think LCDCLK is only ever requested by pxa_device_fb.

I see now that instead of doing:
-       fbi->clk = clk_get(dev, "LCDCLK");
+       fbi->clk = clk_get(inf->clkdev, "LCDCLK");

a better solution would be to directly use pxa_device_fb:
-       fbi->clk = clk_get(dev, "LCDCLK");
+       fbi->clk = clk_get(pxa_device_fb.dev, "LCDCLK");

and then I can avoid doing the clkdev ugliness.

Thanks,
jaya

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/