Re: [RFC 2.6.26-rc3 05/10] pxafb: add shared framebuffer interface

On Sun, Jun 15, 2008 at 2:26 AM, Krzysztof Helt [off-list ref] wrote:

On Thu, 12 Jun 2008 12:59:16 -0400
Jaya Kumar [off-list ref] wrote:

quoted

+     ret = pxafb_map_video_memory(fbi, inf);
+     if (ret == -ENODEV) {
+             dev_err(&dev->dev, "Failed device binding: %d\n", ret);
+             ret = -ENODEV;

This line is redundant as the ret is already -ENODEV.

Arr, sorry about that embarrassing mistake. I don't know why I didn't spot it.

quoted

+             goto failed_free_mem;
+     } else if (ret) {
              dev_err(&dev->dev, "Failed to allocate video RAM: %d\n", ret);
              ret = -ENOMEM;

Probably, there is no need to change the error code (ret). You can drop this line.

Ok. Will do.

Thanks,
jaya

-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php