Re: [Linux-fbdev-devel] [RFC 2.6.26-rc3 05/10] pxafb: add shared framebuffer interface
From: Krzysztof Helt <hidden>
Date: 2008-06-15 06:26:53
On Thu, 12 Jun 2008 12:59:16 -0400 Jaya Kumar [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/video/pxafb.c b/drivers/video/pxafb.c index 89f1b48..434587f 100644 --- a/drivers/video/pxafb.c +++ b/drivers/video/pxafb.c@@ -1701,8 +1725,12 @@ static int __devinit pxafb_probe(struct platform_device *dev) } /* Initialize video memory */ - ret = pxafb_map_video_memory(fbi); - if (ret) { + ret = pxafb_map_video_memory(fbi, inf); + if (ret == -ENODEV) { + dev_err(&dev->dev, "Failed device binding: %d\n", ret); + ret = -ENODEV;
This line is redundant as the ret is already -ENODEV.
+ goto failed_free_mem;
+ } else if (ret) {
dev_err(&dev->dev, "Failed to allocate video RAM: %d\n", ret);
ret = -ENOMEM;Probably, there is no need to change the error code (ret). You can drop this line. Regards, Krzysztof ---------------------------------------------------------------------- Z Map24 Twoja droga jest prosta! Sprawdz! kliknij >>> http://link.interia.pl/f1e3b ------------------------------------------------------------------- List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php