Re: [RFC 2.6.26-rc3 06/10] gumstix: conversion to MFP support and add bluetooth support
flat view
From: Russell King - ARM Linux <hidden>
Date: 2008-06-13 07:43:14
On Thu, Jun 12, 2008 at 12:59:17PM -0400, Jaya Kumar wrote:
quoted hunk ↗ jump to hunk
+static unsigned long gumstix_pin_config[] __initdata = { +#ifdef CONFIG_BT + GPIO12_32KHz, + /* BTUART */ + GPIO42_HWUART_RXD, + GPIO43_HWUART_TXD, + GPIO44_HWUART_CTS, + GPIO45_HWUART_RTSL, +#endif +#ifdef CONFIG_MMC_PXA + /* MMC */ + GPIO6_MMC_CLK, + GPIO53_MMC_CLK, + GPIO8_MMC_CS0, +#endif
Should GPIO configurations depend on whether the driver support's built in or not? Surely the hardware is there irrespective of the kernel's configuration - especially if these are built as a module.
quoted hunk ↗ jump to hunk
static struct clk pxa25x_clks[] = { + { + .name = "CLK_32K", + .ops = &clk_32k_ops, + .rate = 32000,
Most 32kHz clocks are 32768Hz not 32000Hz. Are you sure this is correct? ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php