Re: [RFC 2.6.26-rc3 5/5] mach-pxa: add am200epd support

On Sat, May 31, 2008 at 8:03 PM, Krzysztof Helt [off-list ref] wrote:

Then probably you should also break this patch into two pieces:
- changes which prepare existing stuff for a new driver but do
not break existing things (like export pxa_device_fb)
- the new driver itself (much smaller then)

Ok. I will try to do that.

quoted

+
+#define DEBUG 1

You have left the debug code enabled. If it is intentional it is ok.

Yes, I wanted to keep it there for a few releases to help debug when
any problems arise.

quoted

+static int am200_init_gpio_regs(struct metronomefb_par *par)
+{

Many functions have metronomefb_par parameter, but do not use it.
You can remove the parameter for now.

If it's okay, I'd like to keep it because there are some features
supported in the E-Ink controllers that I haven't implemented yet.
Passing par around is intended to make that possible in future.

Thanks,
jaya

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/