Thread (13 messages) 13 messages, 2 authors, 2008-05-31

Re: [RFC 2.6.26-rc3 0/5] am200epd, pxafb, metronomefb changes v2

From: Krzysztof Helt <hidden>
Date: 2008-05-31 06:39:25

On Sat, 31 May 2008 00:41:50 -0400
Jaya Kumar [off-list ref] wrote:
Hi Eric, arm and fbdev friends,

This is version 2 of this RFC and contains the following updates:
- skip setting g_options to __initdata since it is used both by init and
  probe functions 
- fix ordering of iounmap/release_mem_region
- fix setting of smem_len (thanks to Krzysztof for above feedback)
- make user_wfm_size static as caught by sparse 
Hey, slow down. I have intended to review all your patches, but I have not had
enough time yet. Please wait till Monday.

Also, if the am200epd changes are less then say 40% of the original
driver I would prefer to see an incremental patch, not replacement of
the driver as it is not clear what was changed.

Kind regards,
Krzysztof


----------------------------------------------------------------------
Mucha powraca!
Sprawdz >>> http://link.interia.pl/f1e0d


-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help