Re: [RFC 2.6.26-rc3 1/5] pxafb: module unloading support

On Sat, May 31, 2008 at 2:43 AM, Krzysztof Helt [off-list ref] wrote:

The best solution is to leave it as __devinitdata as it is accessed only by __init
and __devinit functions.
Your previous error was to change the functions to __devinit while changing
the g_options to __initdata.

Ok, understood, I'll leave it as __devinitdata.

While we are on this subject of fbdev options parsing, I think we
should just use the standard module.option = value parameters rather
than doing parsing. Is there consensus in fbdev that we should
deprecate the options parsing stuff? If so, should we start warning
users that the option parsing code will go away? Something like:

int fb_get_options(char *name, char **option)
{
        char *opt, *options = NULL;
        int opt_len, retval = 0;
        int name_len = strlen(name), i;

        pr_warning("Please use module.option = value. The
video=module:options mechanism will be removed in June 2009");
...

Thanks,
jaya

-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/