Re: [Cbe-oss-dev] [patch 0/4] Cell SPE logos
From: Arnd Bergmann <arnd@arndb.de>
Date: 2007-07-13 10:08:16
Also in:
lkml
On Friday 13 July 2007, Geert Uytterhoeven wrote:
quoted
quoted
Summaries: [1] fbdev: extract fb_show_logo_line() [2] fbdev: Add fb_append_extra_logo()This one does give additional code and data to all fbdev users while only being useful to cell machines. Should we fix that?I can protect it by #ifdef CONFIG_PPC_CELL (as long as there are no other users). Would that be OK?
If you want to have an #ifdef in there, it should probably be CONFIG_FB_EXTRA_LOGO and have that autoselected by CONFIG_SPU_BASE. A nicer alternative to the #ifdef might be to mark it __init, so that it will just go away after boot. Not sure if that's safe though. Arnd <>< ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/