Re: [PATCH 1/4 (final?)] ps3fb: thread updates
flat view
From: Andrew Morton <akpm@linux-foundation.org>
Date: 2007-02-21 23:21:00
Also in:
linuxppc-dev
On Tue, 20 Feb 2007 11:42:04 +0100 (CET) Geert Uytterhoeven [off-list ref] wrote:
ps3fb: Replace the kernel_thread and the semaphore by a proper kthread, which is simply woken up when the screen must be updated
<goes off and generates the incremental diff again so we can see what changed> diff -puN drivers/video/ps3fb.c~ps3fb-thread-updates-2 drivers/video/ps3fb.c
--- a/drivers/video/ps3fb.c~ps3fb-thread-updates-2
+++ a/drivers/video/ps3fb.c@@ -32,7 +32,6 @@ #include <linux/ioctl.h> #include <linux/notifier.h> #include <linux/reboot.h> -#include <linux/freezer.h> #include <linux/kthread.h> #include <asm/uaccess.h>
@@ -808,16 +807,13 @@ static int ps3fb_ioctl(struct fb_info *i static int ps3fbd(void *arg) { - DEFINE_WAIT(wait); - DECLARE_WAIT_QUEUE_HEAD(wq); - while (!kthread_should_stop()) { - prepare_to_wait(&wq, &wait, TASK_INTERRUPTIBLE); - if (!ps3fb.is_kicked) - schedule(); - finish_wait(&wq, &wait); - ps3fb.is_kicked = 0; - ps3fb_sync(0); /* single buffer */ + set_current_state(TASK_INTERRUPTIBLE); + if (ps3fb.is_kicked) { + ps3fb.is_kicked = 0; + ps3fb_sync(0); /* single buffer */ + } + schedule(); } return 0; }
_ There's still no try_to_freeze() in there. Shouldn't we have one? ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV