Re: New radeonfb, mostly untested
From: Kronos <hidden>
Date: 2003-09-09 02:55:14
Il Mon, Sep 08, 2003 at 08:06:07AM +0200, Benjamin Herrenschmidt ha scritto:
strangely enough it works here, I have to check what's wrong, I suspect fb_find_mode isn't getting called for me but is for you and it's trying to call check_var. I'll fix that and send a new patch.
I pulled you patch. Now it doesn't oops but fb_find_mode is doing something strange. I added some printk: Starting monitor auto detection... radeonfb: I2C (port 2) ... not found radeonfb: I2C (port 4) ... not found radeonfb: I2C (port 3) ... found CRT display radeonfb: Monitor 1 type CRT found radeonfb: EDID probed [EDID stuff] radeonfb: Monitor 2 type no found We are in radeon_check_modes, just before it calls fb_find_mode: radeonfb: mode_option: 1024x768-8@60 radeonfb: has_default_mode = 0 radeonfb: rinfo->mon1_dbsize 20 radeonfb: calling fb_find_mode radeonfb: fb_find_mode -> 1 radeonfb: rinfo->info.var.xres = 640, rinfo->info.var.yres = 480 fb_find_mode returns 1 (which should mean that we are using specified mode_option), but info.var is set to something else... I can't see what's going wrong here. Btw, I see that you switched to module_param. Maybe we should leave the setup function (#ifndef MODULE), otherwise the driver won't recognise option passed via kernel command line (video=....). radeonfb.option=something will work, but it is a bit ugly... Luca -- Reply-To: kronos@kronoz.cjb.net Home: http://kronoz.cjb.net Dicono che il cane sia il miglior amico dell'uomo. Secondo me non e` vero. Quanti dei vostri amici avete fatto castrare, recentemente? ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf