Re: New radeonfb, mostly untested

On Sun, 2003-09-07 at 20:43, Kronos wrote:

Il Sun, Sep 07, 2003 at 08:23:48PM +0200, Benjamin Herrenschmidt ha scritto: 

quoted

quoted

There's a problem here: sysfs attributes are unregistered after
radeonfb_pci_unregister returns, so we have a small windows where
mon1_EDID and mon2_EDID are invalid and edid1 and edid2 are still
there in sysfs. Ditto for pci_register.

Yup, there is much "polish" still needed on the exit/cleanup path,
though I'm waiting to see what you come up with putting class_device
in there :)

edid1  and edid2  will be  attached to  the class_device,  they will  be
unregistered before the "release". The problem will go away.

Btw, the class_device stuff won't go in, it's too late. I'll maintain it
off tree and submit around 2.6.2.

I don't think it's too late... on the other hand, James is still sitting
on a bunch of patches (hey James !) that should get in asap now...

Ben.




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf