Re: [PATCH v3 07/15] fsnotify: pass arguments of fsnotify() in struct fsnotify_event_info

From
Dan Carpenter <hidden>
Date
2021-06-30 08:46:28
Also in
linux-fsdevel, oe-kbuild, oe-kbuild-all
Reply to
Amir Goldstein, 2021-06-30
On Wed, Jun 30, 2021 at 11:35:32AM +0300, Amir Goldstein wrote:
Do you have feeling of dejavu? ;-)
https://lore.kernel.org/linux-fsdevel/20200730192537.GB13525@quack2.suse.cz/ (local) 
That was a year ago.  I have trouble remembering emails I sent
yesterday.
We've been through this.
Maybe you silenced the smach warning on fsnotify() and the rename to
__fsnotifty()
caused this warning to refloat?
Yes.  Renaming the function will make it show up as a new warning.  Also
this is an email from the kbuild-bot and last years email was from me,
so it's a different tool and a different record of sent messages.

(IMO, you should really just remove the bogus NULL checks because
everyone looking at the warning will think the code is buggy).

regards,
dan carpenter
Thread (54 messages) 54 messages, 5 authors, last reply 2021-07-08
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help