Re: [PATCH 06/12] append_pathname: check the value returned by realloc to avoid segfault
From: Благодаренко Артём <hidden>
Date: 2021-05-25 09:38:08
Hello Wu, Thanks for the patch.
quoted hunk ↗ jump to hunk
On 24 May 2021, at 14:23, Wu Guanghao [off-list ref] wrote: In append_pathname(), we need to add a new path to save the value returned by realloc, otherwise the name->path may be NULL, causing segfault Signed-off-by: Wu Guanghao <redacted> Signed-off-by: Zhiqiang Liu <redacted> --- contrib/fsstress.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)diff --git a/contrib/fsstress.c b/contrib/fsstress.c index 2a983482..530bd920 100644 --- a/contrib/fsstress.c +++ b/contrib/fsstress.c@@ -599,7 +599,7 @@ void add_to_flist(int ft, int id, int parent)void append_pathname(pathname_t * name, char *str) { int len; - + char *path;: len = strlen(str); #ifdef DEBUG if (len && *str == '/' && name->len == 0) {@@ -609,7 +609,13 @@ void append_pathname(pathname_t * name, char *str)} #endif - name->path = realloc(name->path, name->len + 1 + len); + path = realloc(name->path, name->len + 1 + len); + if (path == NULL) { + fprintf(stderr, "fsstress: append_pathname realloc failed\n"); + chadir(homedir);
Did you mean chdir() here?
+ abort(); + } + name->path = path; strcpy(&name->path[name->len], str); name->len += len; } --
Thanks, Best regards, Artem Blagodarenko.