[PATCH 01/12] profile_create_node: set magic before strdup(name) to avoid memory leak
From: Wu Guanghao <hidden>
Date: 2021-05-24 11:19:51
Subsystem:
library code, the rest · Maintainers:
Andrew Morton, Linus Torvalds
If new->magic != PROF_MAGIC_NODE, profile_free_node() don't free node. This will cause the node to be unable to be released correctly and a memory leak will occur. Signed-off-by: Wu Guanghao <redacted> Signed-off-by: Zhiqiang Liu <redacted> Reviewed-by: Wu Bo <redacted> --- lib/support/profile.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/support/profile.c b/lib/support/profile.c
index 585ed595..2eb3a9d1 100644
--- a/lib/support/profile.c
+++ b/lib/support/profile.c@@ -1093,6 +1093,8 @@ errcode_t profile_create_node(const char *name, const char *value, if (!new) return ENOMEM; memset(new, 0, sizeof(struct profile_node)); + new->magic = PROF_MAGIC_NODE; + new->name = strdup(name); if (new->name == 0) { profile_free_node(new);
@@ -1105,7 +1107,6 @@ errcode_t profile_create_node(const char *name, const char *value, return ENOMEM; } } - new->magic = PROF_MAGIC_NODE; *ret_node = new; return 0;
--