Re: [PATCH 07/12] argv_parse: check return value of malloc in argv_parse()
From: Wu Guanghao <hidden>
Date: 2021-05-25 02:32:27
There is a problem with this patch. "argv" is spelled as "arcv". This problem will be resolved in the v2 version. 在 2021/5/24 19:23, Wu Guanghao 写道:
quoted hunk ↗ jump to hunk
In argv_parse(), return value of malloc should be checked whether it is NULL, otherwise, it may cause a segfault error. Signed-off-by: Zhiqiang Liu <redacted> Signed-off-by: Wu Guanghao <redacted> --- lib/support/argv_parse.c | 2 ++ 1 file changed, 2 insertions(+)diff --git a/lib/support/argv_parse.c b/lib/support/argv_parse.c index d22f6344..1ef9c014 100644 --- a/lib/support/argv_parse.c +++ b/lib/support/argv_parse.c@@ -116,6 +116,8 @@ int argv_parse(char *in_buf, int *ret_argc, char ***ret_argv) if (argv == 0) { argv = malloc(sizeof(char *)); free(buf); + if (!arcv) + return -1; } argv[argc] = 0; if (ret_argc)