Re: [PATCH 10/13] fs: clean up __mark_inode_dirty() a bit
flat view
From: Christoph Hellwig <hch@lst.de>
Date: 2021-01-08 09:11:32
Also in:
linux-f2fs-devel, linux-fsdevel, linux-xfs
On Mon, Jan 04, 2021 at 04:54:49PM -0800, Eric Biggers wrote:
quoted hunk ↗ jump to hunk
+ } else { + /* + * Else it's either I_DIRTY_PAGES, I_DIRTY_TIME, or nothing. + * (We don't support setting both I_DIRTY_PAGES and I_DIRTY_TIME + * in one call to __mark_inode_dirty().) + */ + dirtytime = flags & I_DIRTY_TIME; + WARN_ON_ONCE(dirtytime && (flags != I_DIRTY_TIME));
No need for the inner braces here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>