Re: [PATCH 10/13] fs: clean up __mark_inode_dirty() a bit

[PATCH 00/13] lazytime fixes and cleanups · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
[PATCH 01/13] fs: avoid double-writing inodes on lazytime expiration · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 01/13] fs: avoid double-writing inodes on lazytime expiration · Jan Kara <jack@suse.cz> · 2021-01-07
Re: [PATCH 01/13] fs: avoid double-writing inodes on lazytime expiration · Eric Biggers <ebiggers@kernel.org> · 2021-01-07
Re: [PATCH 01/13] fs: avoid double-writing inodes on lazytime expiration · Christoph Hellwig <hch@lst.de> · 2021-01-08
Re: [PATCH 01/13] fs: avoid double-writing inodes on lazytime expiration · Christoph Hellwig <hch@lst.de> · 2021-01-08
Re: [PATCH 01/13] fs: avoid double-writing inodes on lazytime expiration · Eric Biggers <ebiggers@kernel.org> · 2021-01-09
Re: [PATCH 01/13] fs: avoid double-writing inodes on lazytime expiration · Matthew Wilcox <willy@infradead.org> · 2021-01-08
[PATCH 04/13] fat: only specify I_DIRTY_TIME when needed in fat_update_time() · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 04/13] fat: only specify I_DIRTY_TIME when needed in fat_update_time() · Jan Kara <jack@suse.cz> · 2021-01-07
Re: [PATCH 04/13] fat: only specify I_DIRTY_TIME when needed in fat_update_time() · Eric Biggers <ebiggers@kernel.org> · 2021-01-07
[PATCH 03/13] fs: only specify I_DIRTY_TIME when needed in generic_update_time() · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 03/13] fs: only specify I_DIRTY_TIME when needed in generic_update_time() · Christoph Hellwig <hch@lst.de> · 2021-01-08
[PATCH 02/13] gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync() · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 02/13] gfs2: don't worry about I_DIRTY_TIME in gfs2_fsync() · Christoph Hellwig <hch@lst.de> · 2021-01-08
[PATCH 06/13] fs: pass only I_DIRTY_INODE flags to ->dirty_inode · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 06/13] fs: pass only I_DIRTY_INODE flags to ->dirty_inode · Christoph Hellwig <hch@lst.de> · 2021-01-08
[PATCH 13/13] xfs: implement lazytime_expired · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
[PATCH 07/13] fs: correctly document the inode dirty flags · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 07/13] fs: correctly document the inode dirty flags · Christoph Hellwig <hch@lst.de> · 2021-01-08
[PATCH 09/13] fs: drop redundant checks from __writeback_single_inode() · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 09/13] fs: drop redundant checks from __writeback_single_inode() · Christoph Hellwig <hch@lst.de> · 2021-01-08
[PATCH 11/13] fs: add a lazytime_expired method · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 11/13] fs: add a lazytime_expired method · Jan Kara <jack@suse.cz> · 2021-01-07
Re: [PATCH 11/13] fs: add a lazytime_expired method · Eric Biggers <ebiggers@kernel.org> · 2021-01-07
Re: [PATCH 11/13] fs: add a lazytime_expired method · Christoph Hellwig <hch@lst.de> · 2021-01-08
[PATCH 08/13] ext4: simplify i_state checks in __ext4_update_other_inode_time() · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 08/13] ext4: simplify i_state checks in __ext4_update_other_inode_time() · Jan Kara <jack@suse.cz> · 2021-01-07
Re: [PATCH 08/13] ext4: simplify i_state checks in __ext4_update_other_inode_time() · Eric Biggers <ebiggers@kernel.org> · 2021-01-07
[PATCH 12/13] xfs: remove a stale comment from xfs_file_aio_write_checks() · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 12/13] xfs: remove a stale comment from xfs_file_aio_write_checks() · Christoph Hellwig <hch@lst.de> · 2021-01-08
[PATCH 10/13] fs: clean up __mark_inode_dirty() a bit · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 10/13] fs: clean up __mark_inode_dirty() a bit · Christoph Hellwig <hch@lst.de> · 2021-01-08
[PATCH 05/13] fs: don't call ->dirty_inode for lazytime timestamp updates · Eric Biggers <ebiggers@kernel.org> · 2021-01-05
Re: [PATCH 05/13] fs: don't call ->dirty_inode for lazytime timestamp updates · Jan Kara <jack@suse.cz> · 2021-01-07
Re: [PATCH 05/13] fs: don't call ->dirty_inode for lazytime timestamp updates · Jan Kara <jack@suse.cz> · 2021-01-07
Re: [PATCH 05/13] fs: don't call ->dirty_inode for lazytime timestamp updates · Christoph Hellwig <hch@lst.de> · 2021-01-08

From: Christoph Hellwig <hch@lst.de>
Date: 2021-01-08 09:11:32
Also in: linux-ext4, linux-f2fs-devel, linux-fsdevel

On Mon, Jan 04, 2021 at 04:54:49PM -0800, Eric Biggers wrote:

+	} else {
+		/*
+		 * Else it's either I_DIRTY_PAGES, I_DIRTY_TIME, or nothing.
+		 * (We don't support setting both I_DIRTY_PAGES and I_DIRTY_TIME
+		 * in one call to __mark_inode_dirty().)
+		 */
+		dirtytime = flags & I_DIRTY_TIME;
+		WARN_ON_ONCE(dirtytime && (flags != I_DIRTY_TIME));

No need for the inner braces here.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help